Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 )
Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. ...................................................................... Patch Set 2: > (4 comments) > > Thanks for the review. What do you think about: > Is "Query with implicit casts:" a good description? > Is the EXPLAIN header the right place for this output? It seems good to me, but I would ping Greg Rahn in the Jira, maybe he has some ideas. I have one issue with the current output: as I saw in the .test files, queries are printed in one line by default, which can make complex queries very difficult to read. It would be much nicer to break them at logical points, but I have no idea how to do it easily. -- To view, visit http://gerrit.cloudera.org:8080/11719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55c3bdacc295137f66b2316a912fc347da30d6b0 Gerrit-Change-Number: 11719 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 18 Oct 2018 22:19:38 +0000 Gerrit-HasComments: No
