Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11732 )
Change subject: IMPALA-7717: Handle concurrent partition changes in local catalog mode ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/11732/3/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/11732/3/common/thrift/CatalogService.thrift@384 PS3, Line 384: 1. The partition that the partial fetch RPC is looking for has already been dropped. > this is true of all the *_NOT_FOUND cases. bring this comment to the top of It is probably kinda obvious from _NOT_FOUND part. Omitting it. Just retaining (2) http://gerrit.cloudera.org:8080/#/c/11732/3/common/thrift/CatalogService.thrift@386 PS3, Line 386: can potentially > remove (they do change, easily, often) Done http://gerrit.cloudera.org:8080/#/c/11732/3/common/thrift/CatalogService.thrift@387 PS3, Line 387: a > remove Done http://gerrit.cloudera.org:8080/#/c/11732/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/11732/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1716 PS3, Line 1716: new TG > good catch to not use "resp" since it may send back lots of stuff that will Yep. -- To view, visit http://gerrit.cloudera.org:8080/11732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2aa103ee159ce9478af9b5b27b36bc0cc286f442 Gerrit-Change-Number: 11732 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Adrian Ng (389) Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 00:06:27 +0000 Gerrit-HasComments: Yes
