Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11734 )
Change subject: IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/11734/4/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/11734/4/fe/src/main/java/org/apache/impala/util/SentryProxy.java@172 PS4, Line 172: String > This is lower case as of now. However, it's probably a good idea to not ass got it. keeping track of what's from sentry and what isn't and how that may or may not change over time is error prone. how about we just canonicalize up-front here to lower-case strings? perhaps a cleaner option is just have stuff that comes back from Sentry conform to data structures used in Impala. So in this case, that Map could be a CatalogObjectCache. If you canonicalize the map strings, then you'd need to lower-case in the look-up; if that cache is used, then it would just fall-out. either way, but please add a comment in each of the places I raised a question since the assumptions are currently unclear and error-prone. http://gerrit.cloudera.org:8080/#/c/11734/4/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: http://gerrit.cloudera.org:8080/#/c/11734/4/tests/authorization/test_grant_revoke.py@386 PS4, Line 386: grp.getgrnam( > It's to get a group name. oh... its from the import. http://gerrit.cloudera.org:8080/#/c/11734/4/tests/authorization/test_grant_revoke.py@388 PS4, Line 388: "invalidate metadata" > The issue is with role names having different cases and not with the privil sorry, meant role. this is an e2e test so if could be done here? anyways, if its not possible or extremely difficult, pls add a comment/perhaps a todo. this seems a bit circuitous to debug a case issue. -- To view, visit http://gerrit.cloudera.org:8080/11734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa6f626ad3df4e9321ed18273d045517bc099c2 Gerrit-Change-Number: 11734 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 16:32:28 +0000 Gerrit-HasComments: Yes
