Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11630 )
Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Two nits. Joe, Phil, would appreciate you taking a quick look - I'm going to post a new patchset, since I know Sean is otherwise occupied. http://gerrit.cloudera.org:8080/#/c/11630/6/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/11630/6/tests/query_test/test_insert.py@112 PS6, Line 112: # This fails against ABFS due HADOOP-15860. It succeeds if the partition name Can you add a SkipIfABFS to this test, too? http://gerrit.cloudera.org:8080/#/c/11630/6/tests/util/abfs_util.py File tests/util/abfs_util.py: http://gerrit.cloudera.org:8080/#/c/11630/6/tests/util/abfs_util.py@32 PS6, Line 32: def hadoop_fs_shell(self, command): Methods used only within the class are traditionally prefixed by an underscore; here and below. -- To view, visit http://gerrit.cloudera.org:8080/11630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5120b071760e7655e78902dce8483f8f54de445d Gerrit-Change-Number: 11630 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 22:11:08 +0000 Gerrit-HasComments: Yes
