Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 )
Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/11575/3/be/src/exec/hdfs-parquet-scanner.h File be/src/exec/hdfs-parquet-scanner.h: http://gerrit.cloudera.org:8080/#/c/11575/3/be/src/exec/hdfs-parquet-scanner.h@468 PS3, Line 468: /// to this counter, (2) when a page that is not compressed is read, its size is added to line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11575/3/be/src/exec/hdfs-parquet-scanner.h@661 PS3, Line 661: /// Update the counter parquet_compressed_page_size_counter_ with the given compressed page size line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/11575/3/be/src/exec/hdfs-parquet-scanner.h@664 PS3, Line 664: /// Update the counter parquet_uncompressed_page_size_counter_ with the given uncompressed page size line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/11575/3/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: http://gerrit.cloudera.org:8080/#/c/11575/3/be/src/exec/hdfs-scan-node-base.h@538 PS3, Line 538: /// the size of a single column that is scanned by the scan node. The scan node tracks the line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/11575/3/be/src/exec/hdfs-scan-node-base.h@539 PS3, Line 539: /// number of bytes read for each column it processes, and when the scan node is closed, it line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/11575/3/be/src/exec/hdfs-scan-node-base.h@542 PS3, Line 542: RuntimeProfile::SummaryStatsCounter* uncompressed_data_read_per_column_counter_ = nullptr; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/11575/3/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/11575/3/be/src/exec/hdfs-scan-node-base.cc@376 PS3, Line 376: uncompressed_data_read_per_column_counter_ = ADD_SUMMARY_STATS_COUNTER(runtime_profile(), line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/11575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I322f9b324b6828df28e5caf79529085c43d7c817 Gerrit-Change-Number: 11575 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Mon, 22 Oct 2018 20:54:03 +0000 Gerrit-HasComments: Yes
