Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 )
Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/11760/4/fe/src/test/java/org/apache/impala/analysis/BaseRewriteRulesTest.java File fe/src/test/java/org/apache/impala/analysis/BaseRewriteRulesTest.java: http://gerrit.cloudera.org:8080/#/c/11760/4/fe/src/test/java/org/apache/impala/analysis/BaseRewriteRulesTest.java@66 PS4, Line 66: public Expr RewritesOk(String tableName, String exprStr, ExprRewriteRule rule, String expectedExprStr) line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/11760/4/fe/src/test/java/org/apache/impala/analysis/BaseRewriteRulesTest.java@71 PS4, Line 71: public Expr RewritesOk(String exprStr, List<ExprRewriteRule> rules, String expectedExprStr) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/11760/4/fe/src/test/java/org/apache/impala/analysis/BaseRewriteRulesTest.java@88 PS4, Line 88: public Expr RewritesOkWhereExpr(String exprStr, ExprRewriteRule rule, String expectedExprStr) line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/11760/4/fe/src/test/java/org/apache/impala/analysis/BaseRewriteRulesTest.java@90 PS4, Line 90: return RewritesOkWhereExpr("functional.alltypessmall", exprStr, rule, expectedExprStr); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11760/4/fe/src/test/java/org/apache/impala/analysis/BaseRewriteRulesTest.java@93 PS4, Line 93: public Expr RewritesOkWhereExpr(String tableName, String exprStr, ExprRewriteRule rule, String expectedExprStr) line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/11760/4/fe/src/test/java/org/apache/impala/analysis/BaseRewriteRulesTest.java@95 PS4, Line 95: return RewritesOkWhereExpr(tableName, exprStr, Lists.newArrayList(rule), expectedExprStr); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/11760/4/fe/src/test/java/org/apache/impala/analysis/BaseRewriteRulesTest.java@98 PS4, Line 98: public Expr RewritesOkWhereExpr(String tableName, String exprStr, List<ExprRewriteRule> rules, line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/11760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I526654d8546e17b2545c42cc59dab66d9fe1b163 Gerrit-Change-Number: 11760 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Oct 2018 19:48:22 +0000 Gerrit-HasComments: Yes
