David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11789 )
Change subject: IMPALA-7758: Fix LOCATION clause when creating chars_formats_* ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11789/1/testdata/bin/load-dependent-tables.sql File testdata/bin/load-dependent-tables.sql: http://gerrit.cloudera.org:8080/#/c/11789/1/testdata/bin/load-dependent-tables.sql@42 PS1, Line 42: LOCATION '${hiveconf:hive.metastore.warehouse.dir}/alltypesmixedformat'; > Is this also a problem? It doesn't appear to be? That line was committed six years ago. But we should probably be consistent. I'll change that line, and kick off another round of tests. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/11789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I781b484e7a15ccaa5de590563d68b3dca6a658e5 Gerrit-Change-Number: 11789 Gerrit-PatchSet: 1 Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Oct 2018 18:43:13 +0000 Gerrit-HasComments: Yes
