Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 )
Change subject: IMPALA-6323 Allow constant analytic window expressions. ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/11556/5/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/11556/5/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@91 PS5, Line 91: { remove. as in L89 http://gerrit.cloudera.org:8080/#/c/11556/6/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/11556/6/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@91 PS6, Line 91: { return true; } nit: if we're making any changes, pls remove these braces as mentioned earlier. -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 6 Gerrit-Owner: Michal Ostrowski <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Michal Ostrowski <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 25 Oct 2018 19:11:03 +0000 Gerrit-HasComments: Yes
