Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11794 )
Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata ...................................................................... Patch Set 4: > Patch Set 4: > > > Yes, I created some follow-up JIRAs for this. > > a) https://issues.apache.org/jira/browse/IMPALA-7764 > > This was very generic ("add unit tests.") We have a specific case here that > we need to add to our tests, which involves (if I'm reading things right) > removing the last permission from Sentry. That seems sensible to do as an > end-to-end test (in custom cluster?). > > Anyway--are we working on this right now? > > > b) https://issues.apache.org/jira/browse/IMPALA-7762 > > Thanks. It was a subtle bug and it was difficult to write an end-to-end test to reproduce this because we need to get the timing right. I did some end-to-end test for a similar issue but it was easier to reproduce: https://github.com/apache/impala/blob/master/tests/authorization/test_grant_revoke.py#L373-L393 Anyway, yes, I'm working on beefing up tests related to SentryProxy (which includes unit tests and end-to-end tests). I'll rename the subject in JIRA to make it clear. -- To view, visit http://gerrit.cloudera.org:8080/11794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e0db2b1f727476f489c732c4f4e5bc1582429f Gerrit-Change-Number: 11794 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Mon, 29 Oct 2018 16:22:28 +0000 Gerrit-HasComments: No
