Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11810 )
Change subject: IMPALA-5031: Make UBSAN-friendly arithmetic generic ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Just had a comment about comments - it feels a little cryptic to me (although may be obvious for some people). http://gerrit.cloudera.org:8080/#/c/11810/1/be/src/util/arithmetic-util.h File be/src/util/arithmetic-util.h: http://gerrit.cloudera.org:8080/#/c/11810/1/be/src/util/arithmetic-util.h@116 PS1, Line 116: enum class Ring { INTEGER, FLOAT, NEITHER }; I feel like there's some context missing here. I guess it's to enable generic logic over integral and floating point types, which are both support multiplication and addition but have some subtle differences. -- To view, visit http://gerrit.cloudera.org:8080/11810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73bec71e59c5a921003d0ebca52a1d4e49bbef66 Gerrit-Change-Number: 11810 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 29 Oct 2018 20:49:43 +0000 Gerrit-HasComments: Yes
