Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11591 )
Change subject: IMPALA-6742: Profiles of running queries should include execution summary. ...................................................................... Patch Set 2: Hi Joe, thanks a lot for the very good review and sorry for late update. I just uploaded a new rev. Interestingly, some tests in test_observability failed locally but all is clean in jenkins. One question about your comment about line 637, I saw other places included [[noreturn]], what's the guideline for having it or not? thanks. -- To view, visit http://gerrit.cloudera.org:8080/11591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc7f714c9427d4b26d4e78cf27ceca2b0b336699 Gerrit-Change-Number: 11591 Gerrit-PatchSet: 2 Gerrit-Owner: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Comment-Date: Tue, 30 Oct 2018 17:36:59 +0000 Gerrit-HasComments: No