Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 2:

(6 comments)

This patch was merged with Tiany's +2, so I am uploading a new patch with the 
updates requested by Adrian and Vuk.

http://gerrit.cloudera.org:8080/#/c/11809/2/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

http://gerrit.cloudera.org:8080/#/c/11809/2/docs/topics/impala_config_options.xml@367
PS2, Line 367:  is high
> We can say "reaches 60% of JVM heap size" to be specific.
Done


http://gerrit.cloudera.org:8080/#/c/11809/2/docs/topics/impala_config_options.xml@368
PS2, Line 368: certain
> We can say invalidates 10% of the least recently used tables.
Done


http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@355
PS3, Line 355: small
> bounded
Done


http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@363
PS3, Line 363: specified time period. T
> in seconds.
Done


http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@365
PS3, Line 365: Java garbage collection-based
> simplify to: Memory-based
Done


http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@373
PS3, Line 373: but the feature could potentially
             :         cause performance risks
> do we have standardized phrasing around memory knobs? something like, "may
Changed to: the feature could potentially cause performance issues and may 
require tuning.



--
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tianyi Wang <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
Gerrit-Comment-Date: Wed, 31 Oct 2018 18:46:37 +0000
Gerrit-HasComments: Yes

Reply via email to