Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11854 )
Change subject: IMPALA-7791: Compute AggregationNode's estimated rows using # instances ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11854/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11854/1//COMMIT_MSG@13 PS1, Line 13: to nit: extra word http://gerrit.cloudera.org:8080/#/c/11854/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/11854/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@474 PS1, Line 474: perInstanceCardinality == -1 does this (getPerInstanceNdv returning -1) mean that we dont have the necessary data to cap the estimate based on input cardinality? -- To view, visit http://gerrit.cloudera.org:8080/11854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cb9746fafa3e5952e28caa952837e285bcc22ac Gerrit-Change-Number: 11854 Gerrit-PatchSet: 1 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 02 Nov 2018 00:49:19 +0000 Gerrit-HasComments: Yes
