Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11864
Change subject: IMPALA-7775: fix some lifecycle issues in statestore/session tests ...................................................................... IMPALA-7775: fix some lifecycle issues in statestore/session tests Background threads from the Statestore's thread pool continued running in the background and could dereference invalid memory. We make sure these threads are cleaned up before moving onto the next test. Note that we don't clean up all background threads, just the ones that had caused issues here. The statestore tests also had an issue with the lifetime of the string flags FLAGS_ssl_*_certificate. Those were overwritten with new values while the thread pool threads were still running, which could cause use-after-free bugs. Testing: Looped the tests under ASAN with the "stress" utility running at the same time to flush out races. Ran core tests. Change-Id: I3b25c8b8a96bfa1183ce273b3bb4debde234dd01 --- M be/src/service/session-expiry-test.cc M be/src/statestore/statestore-test.cc M be/src/statestore/statestore.cc M be/src/statestore/statestore.h 4 files changed, 69 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/11864/1 -- To view, visit http://gerrit.cloudera.org:8080/11864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3b25c8b8a96bfa1183ce273b3bb4debde234dd01 Gerrit-Change-Number: 11864 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]>
