Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11799 )

Change subject: IMPALA-402: test for random partitioning in insert
......................................................................


Patch Set 1:

(1 comment)

I somehow missed your comment, sorry about that.

http://gerrit.cloudera.org:8080/#/c/11799/1/tests/query_test/test_insert.py
File tests/query_test/test_insert.py:

http://gerrit.cloudera.org:8080/#/c/11799/1/tests/query_test/test_insert.py@153
PS1, Line 153:   @UniqueDatabase.parametrize(sync_ddl=True)
> Is this needed to make sure that the database exists on all workers before
It's needed for tests that run with the sync_ddl=1 dimension and use the unique 
database fixture. Most tests don't run with sync_ddl=0, which means they only 
issue queries to one coordinator.



--
To view, visit http://gerrit.cloudera.org:8080/11799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bbca5c64977cadf79dabd72f0c8876a40fdf410
Gerrit-Change-Number: 11799
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Mon, 05 Nov 2018 18:01:40 +0000
Gerrit-HasComments: Yes

Reply via email to