Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 )
Change subject: IMPALA-6658: improve Parquet RLE for low bit widths ...................................................................... Patch Set 9: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/11582/8/be/src/util/rle-encoding.h File be/src/util/rle-encoding.h: http://gerrit.cloudera.org:8080/#/c/11582/8/be/src/util/rle-encoding.h@259 PS8, Line 259: MaxBufferSize > OK, interesting. I think this is what you mean (see below). Hmm, shouldn't data_bytes be the same on both branches? I think that we are actually a bit pessimistic in the bit_width > 2 case, because the last "partial" run is calculated as if it was a full MAX_VALUES_PER_LITERAL_RUN run. I do not think that giving a closer estimation is very important though, so I do not want to nitpick about this too much. -- To view, visit http://gerrit.cloudera.org:8080/11582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I191a581d3f699b6669e48ac9dc39c76ed77c4a76 Gerrit-Change-Number: 11582 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 21:37:56 +0000 Gerrit-HasComments: Yes
