Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 )
Change subject: IMPALA-5004: Switch to sorting node for large TopN queries ...................................................................... Patch Set 10: Tests are passing now. So this patch should be good to merge. The first set of failures in https://jenkins.impala.io/job/gerrit-verify-dryrun/3373/ was due to a change that I have now reverted. The change attempted to dynamically switch from TopN to Sort if the input cardinality of the TopN operator exceeded the value of the limit, after thinking through this change some more and doing some more profiling I realized it does not make sense to implement. The second set of failures in https://jenkins.impala.io/job/gerrit-verify-dryrun/3413/ seems to be due to flaky test failures. -- To view, visit http://gerrit.cloudera.org:8080/11698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34c9db33c9302b55e9978f53f9c7061f2806c8a9 Gerrit-Change-Number: 11698 Gerrit-PatchSet: 10 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 06 Nov 2018 20:23:01 +0000 Gerrit-HasComments: No
