Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11883 )
Change subject: IMPALA-7808: Refactor Analyzer for easier debugging ...................................................................... Patch Set 3: (11 comments) http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@219 PS3, Line 219: // When there is a LIMIT clause in conjunction with an ORDER BY, the ordering exprs line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@274 PS3, Line 274: "Star exprs only expand to scalar-typed columns because complex-typed exprs " + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@326 PS3, Line 326: * Generates and registers !empty() predicates to filter out empty collections directly line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@341 PS3, Line 341: * are required so are checked for !empty. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@347 PS3, Line 347: * TODO: In some cases, it is possible to generate !empty() predicates for a correlated line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@366 PS3, Line 366: if (analyzer_.isOuterJoined(ref.getResolvedPath().getRootDesc().getId())) continue; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@425 PS3, Line 425: throw new AnalysisException("'*' expression in select list requires FROM clause."); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@665 PS3, Line 665: List<Expr> substAggExprs = Expr.substituteList(aggExprs_, ndvSmap_, analyzer_, false); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@681 PS3, Line 681: // However the original COUNT(c) should have returned 0 instead of NULL in this case. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@756 PS3, Line 756: if (!sortInfo_.getSortExprs().get(i).isBound(multiAggInfo_.getResultTupleId())) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11883/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@860 PS3, Line 860: // If 'exprRewritten' is true, we have to compose the new smap with the existing one. line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/11883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I576c80c4c7a974df226fc91d8903db275069ed52 Gerrit-Change-Number: 11883 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Nov 2018 22:20:29 +0000 Gerrit-HasComments: Yes
