Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 )
Change subject: IMPALA-7738: Implement timeouts for HDFS open calls ...................................................................... Patch Set 4: Thanks! I was a little surprised to see hdfs-monitored-ops have different signatures for the cached vs. non-cached file handles. Ultimately, we're trying to implement hdfsOpenWithTimeout(), and I would have expected existing code to be amended to use that. Equivalently, could we be using lambdas or similar to have a totally generic "timeout-pool" for this sort of operation? -- To view, visit http://gerrit.cloudera.org:8080/11874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia14403ca5f3f19c6d5f61b9ab2306b0ad3267454 Gerrit-Change-Number: 11874 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 07 Nov 2018 23:50:53 +0000 Gerrit-HasComments: No
