Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11901 )
Change subject: IMPALA-7528: Fix division by zero when computing cardinalities ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11901/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/11901/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java@367 PS2, Line 367: if (slots.rhsNumRows() > rhsCard) rhsAdjNdv *= rhsCard / slots.rhsNumRows(); > nit: Add a comment that explains adjusting to 1 part. It is a bit subtle. Done http://gerrit.cloudera.org:8080/#/c/11901/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/11901/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@708 PS2, Line 708: testCardinalityDivisionByZero > nit: rename this to testNullColumnJoinCardinality() or something? Done -- To view, visit http://gerrit.cloudera.org:8080/11901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieedd51d3ad6131a4ea2a5883f05104e6a0f2cd14 Gerrit-Change-Number: 11901 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 08 Nov 2018 01:40:43 +0000 Gerrit-HasComments: Yes
