Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11914 )
Change subject: IMPALA-7836: [DOCS] Document TOPN_BYTES_LIMIT query option ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/11914/1/docs/topics/impala_topn_bytes_limit.xml File docs/topics/impala_topn_bytes_limit.xml: http://gerrit.cloudera.org:8080/#/c/11914/1/docs/topics/impala_topn_bytes_limit.xml@44 PS1, Line 44: number > nit: amount Done http://gerrit.cloudera.org:8080/#/c/11914/1/docs/topics/impala_topn_bytes_limit.xml@45 PS1, Line 45: queries > nit: operators I am going to leave this as "queries". The word operator is a specific term in SQL and has a keyword associated with each operator. To avoid confusing users - like I was confused and looked for TOPN keyword, let's use "queries". Other databases also refer it as TOPN queries, BTW. http://gerrit.cloudera.org:8080/#/c/11914/1/docs/topics/impala_topn_bytes_limit.xml@46 PS1, Line 46: top-N</term> queries are the queries that > <term>top-N</term> operators are triggered by queries that... Same as above http://gerrit.cloudera.org:8080/#/c/11914/1/docs/topics/impala_topn_bytes_limit.xml@55 PS1, Line 55: sort > should "sort" be marked as a term also? Done http://gerrit.cloudera.org:8080/#/c/11914/1/docs/topics/impala_topn_bytes_limit.xml@55 PS1, Line 55: the <term>top-N</term> operator Tim and Sahil, Here, do we have a better word than "operator" or "query" to refer to TOPN and SORT? -- To view, visit http://gerrit.cloudera.org:8080/11914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7109c2949ee5137d8b4a748227948b79bd93f52 Gerrit-Change-Number: 11914 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 13 Nov 2018 00:01:08 +0000 Gerrit-HasComments: Yes
