Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 )
Change subject: IMPALA-7842: Make query fragments available for unit testing ...................................................................... Patch Set 2: (2 comments) Thanks, Phil, for the review. Addressed your comments. http://gerrit.cloudera.org:8080/#/c/11920/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11920/1/fe/src/main/java/org/apache/impala/service/Frontend.java@188 PS1, Line 188: protected final TQueryCtx queryCtx_; : protected final StringBuilder explainBuf_; : protected boolean capturePlan_; : protected List<PlanFragment> pla > Are these intentionally public? Made these protected, some final. http://gerrit.cloudera.org:8080/#/c/11920/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1227 PS1, Line 1227: StringBuilder explainString) > This should be on line 1220? There are actually three public entry points. Retained the older two to avoid changing more code than necessary. Can clean that up later. -- To view, visit http://gerrit.cloudera.org:8080/11920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c615dbc1d14685a6966c5ca7538777cdc80b74d Gerrit-Change-Number: 11920 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 13 Nov 2018 21:41:28 +0000 Gerrit-HasComments: Yes
