Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11880 )

Change subject: IMPALA-7764: Improve SentryProxy test coverage
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

Carry Vuk's +2.

http://gerrit.cloudera.org:8080/#/c/11880/3/fe/src/test/java/org/apache/impala/util/SentryProxyTest.java
File fe/src/test/java/org/apache/impala/util/SentryProxyTest.java:

http://gerrit.cloudera.org:8080/#/c/11880/3/fe/src/test/java/org/apache/impala/util/SentryProxyTest.java@291
PS3, Line 291:
> ok, add a brief comment to clarify the purpose of these differences.
Done



--
To view, visit http://gerrit.cloudera.org:8080/11880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1190638283f051cc37fda7ea5dd0c5e8a70d40db
Gerrit-Change-Number: 11880
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Adam Holley <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
Gerrit-Comment-Date: Wed, 14 Nov 2018 03:30:52 +0000
Gerrit-HasComments: Yes

Reply via email to