Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11811 )
Change subject: IMPALA-5031: Zero-length arrays are undefined behavior ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11811/1/be/src/runtime/row-batch-serialize-test.cc File be/src/runtime/row-batch-serialize-test.cc: http://gerrit.cloudera.org:8080/#/c/11811/1/be/src/runtime/row-batch-serialize-test.cc@242 PS1, Line 242: int len = rand() % (MAX_STRING_LEN + 1); > I think we want to generate empty strings as random values. Why not just ma Good point! Done. -- To view, visit http://gerrit.cloudera.org:8080/11811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93f7d0b0506e4b6a2ff3303477d887a428431f96 Gerrit-Change-Number: 11811 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Jinchul Kim <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 17 Nov 2018 16:07:40 +0000 Gerrit-HasComments: Yes
