Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 )
Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/11888/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/11888/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3358 PS6, Line 3358: * 4) perform a refresh on authorization metadata. > 'refresh authorization' does not match any of these three items, so it coul Done http://gerrit.cloudera.org:8080/#/c/11888/6/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java: http://gerrit.cloudera.org:8080/#/c/11888/6/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@1470 PS6, Line 1470: : /** : * Test admin functions are output correctly. : */ > This is done in more than places. A function like createTestAuthConfig coul Done http://gerrit.cloudera.org:8080/#/c/11888/6/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@1474 PS6, Line 1474: > createAnalysisCtx has an overload that expects a single AuthorizationConfig Done http://gerrit.cloudera.org:8080/#/c/11888/6/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/11888/6/tests/authorization/test_authorization.py@541 PS6, Line 541: on > typo: one? Done http://gerrit.cloudera.org:8080/#/c/11888/6/tests/authorization/test_authorization.py@556 PS6, Line 556: s > 'unique_role' could also get a cleanup method similarly to 'unique_database Initially I thought of doing that, but creating a role requires Sentry to be enabled, the user needs to be part of Sentry admin, which can complicate things. -- To view, visit http://gerrit.cloudera.org:8080/11888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5459e1c97b12dee307e0cf85b94a9f66fd9d9a8c Gerrit-Change-Number: 11888 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Nov 2018 19:32:06 +0000 Gerrit-HasComments: Yes
