Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )
Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Sorry, I somehow missed the review request, only found two nits, but otherwise lgtm. http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_fixed_issues.xml File docs/topics/impala_fixed_issues.xml: http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_fixed_issues.xml@48 PS4, Line 48: <concept rev="3.1.0" id="fixed_issues_3_1_0"> Nit: don't we need the 'All 3.1.x subsections go under here' xml comment here just for being consistent? http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_new_features.xml File docs/topics/impala_new_features.xml: http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_new_features.xml@48 PS4, Line 48: <concept rev="3.1.0" id="new_features_31"> Nit: the concepts under have an xml comment "All ... new features go under here" -- To view, visit http://gerrit.cloudera.org:8080/11922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169 Gerrit-Change-Number: 11922 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 21 Nov 2018 16:19:05 +0000 Gerrit-HasComments: Yes
