Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 )
Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11227/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/11227/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@564 PS3, Line 564: if (useExistingFds) { : stats = resetAndLoadFileMetadata(partDir, Collections.singletonList(partition)); : } else { : stats = refreshFileMetadata(partDir, Collections.singletonList(partition)); : } This looks incorrect. Shouldn't we swap the if and else? -- To view, visit http://gerrit.cloudera.org:8080/11227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2051b96599206164aaa06ecbdf64374c46eda956 Gerrit-Change-Number: 11227 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 21 Nov 2018 20:13:30 +0000 Gerrit-HasComments: Yes
