Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11976 )
Change subject: IMPALA-7851: fix underflow in ReserveSpace() ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11976/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11976/2//COMMIT_MSG@9 PS2, Line 9: The overflow could result in reserving huge amounts of memory in the > Could you provide some more context on why the fix works? eg. how does it n It's really an underflow now that I think about it. Updated the message wiht a better explanation -- To view, visit http://gerrit.cloudera.org:8080/11976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaec944f2149a6b9b605a5a885357fd54754dc046 Gerrit-Change-Number: 11976 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 21 Nov 2018 21:45:40 +0000 Gerrit-HasComments: Yes
