Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 )
Change subject: IMPALA-7881: Visualize AST for easier debugging ...................................................................... Patch Set 2: Code-Review+1 (2 comments) I had a look because I was curious and had a small nit. http://gerrit.cloudera.org:8080/#/c/11980/2/fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java File fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java: http://gerrit.cloudera.org:8080/#/c/11980/2/fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java@77 PS2, Line 77: private TreeVisualizer treeVis; nit: I think we end member variables with an _ in Java, too. http://gerrit.cloudera.org:8080/#/c/11980/2/fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java@124 PS2, Line 124: Method visMethod; On first glance I found this a bit tricky to read since visit and visualize both start with "vis". Maybe "print" or "render" are alternatives to "visualize", or just "visualizeMethod"? -- To view, visit http://gerrit.cloudera.org:8080/11980 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114 Gerrit-Change-Number: 11980 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 22 Nov 2018 03:09:38 +0000 Gerrit-HasComments: Yes
