Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 )
Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser ...................................................................... Patch Set 4: (4 comments) Fredy, addressed the generics issues as you suggested. Turned out to be a bit tricky. Please take another look. http://gerrit.cloudera.org:8080/#/c/11954/4/fe/src/main/java/org/apache/impala/common/TreeNode.java File fe/src/main/java/org/apache/impala/common/TreeNode.java: http://gerrit.cloudera.org:8080/#/c/11954/4/fe/src/main/java/org/apache/impala/common/TreeNode.java@132 PS4, Line 132: ? > this should be Class<C> Turns out it should be Class<D>. There was a caller that had the wrong list type, had to fix that so the revised signature would work. http://gerrit.cloudera.org:8080/#/c/11954/4/fe/src/main/java/org/apache/impala/common/TreeNode.java@166 PS4, Line 166: ? > this should be Class<C> Turns out it should be Class<D>. There was a caller that had the wrong list type, had to fix that so the revised signature would work. This then forced a (correct) change to a member variable, and so on. http://gerrit.cloudera.org:8080/#/c/11954/4/fe/src/main/java/org/apache/impala/common/TreeNode.java@184 PS4, Line 184: public boolean contains(Class<?> cl) > this should be public <C extends TreeNode<NodeType>> boolean contains(Class Done http://gerrit.cloudera.org:8080/#/c/11954/4/fe/src/main/java/org/apache/impala/common/TreeNode.java@213 PS4, Line 213: <?> > this should be Class<C> Actually ? extends C. -- To view, visit http://gerrit.cloudera.org:8080/11954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebab7dccdb4b2fa0b5ca812beab0e8bdba39f539 Gerrit-Change-Number: 11954 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 18:14:25 +0000 Gerrit-HasComments: Yes
