David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11851 )
Change subject: IMPALA-7790: Skip some Kudu tests if use_hybrid_clock=false ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Couple of minor nits, otherwise looks fine to me. http://gerrit.cloudera.org:8080/#/c/11851/3/tests/common/kudu_test_suite.py File tests/common/kudu_test_suite.py: http://gerrit.cloudera.org:8080/#/c/11851/3/tests/common/kudu_test_suite.py@49 PS3, Line 49: raise Exception("Multi-master not supported yet") Nit: might be marginally nicer to raise a NotImplementedError http://gerrit.cloudera.org:8080/#/c/11851/3/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/11851/3/tests/common/skip.py@106 PS3, Line 106: reiies Nit: misspelling -- To view, visit http://gerrit.cloudera.org:8080/11851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c9ed4a4ea0720760d65c98acfc394247ab2f1a2 Gerrit-Change-Number: 11851 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 20:54:50 +0000 Gerrit-HasComments: Yes
