Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11990 )
Change subject: IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11990/3/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/11990/3/shell/impala_shell.py@1736 PS3, Line 1736: print_to_stderr('^C') > I've not had the opportunity to run this, but does this diff mean that the No, original intro = '\n' never works anyway since at L1765 in the finally block we always set it to intro = '' -- To view, visit http://gerrit.cloudera.org:8080/11990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80d7b2c2350224d88d0bfeb1745d9ed76e83cf6d Gerrit-Change-Number: 11990 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 27 Nov 2018 19:01:23 +0000 Gerrit-HasComments: Yes
