Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11992 )
Change subject: IMPALA-2343: Add lifecycle timeline to plan nodes ...................................................................... Patch Set 7: I also noted that a lot of Open() and GetNext() implementations have similar preambles, e.g. SCOPED_TIMER(runtime_profile_->total_time_counter()); ScopedGetNextEventAdder ea(this, eos); DCHECK(row_batch != NULL); RETURN_IF_ERROR(ExecDebugAction(TExecNodePhase::GETNEXT, state)); RETURN_IF_CANCELLED(state); RETURN_IF_ERROR(QueryMaintenance(state)); Some leave parts of those out, though it's not clear whether that happens on purpose. Should we file a follow-up Jira to unify the preambles, possibly with some generic macro? -- To view, visit http://gerrit.cloudera.org:8080/11992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15341bdb15022bad9814882689ce5cb2939f4653 Gerrit-Change-Number: 11992 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Wed, 28 Nov 2018 01:41:15 +0000 Gerrit-HasComments: No
