Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11947 )
Change subject: IMPALA-6656: BufferAllocator observability ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/11947/3/be/src/runtime/bufferpool/buffer-allocator.cc File be/src/runtime/bufferpool/buffer-allocator.cc: http://gerrit.cloudera.org:8080/#/c/11947/3/be/src/runtime/bufferpool/buffer-allocator.cc@38 PS3, Line 38: // various useful statistics that would be too expensive to update every allocation. nit: Maybe it's worth to mention that we should keep it as a power-of-2, so the calculation of the modulo remain more efficient. http://gerrit.cloudera.org:8080/#/c/11947/3/be/src/runtime/bufferpool/buffer-allocator.cc@367 PS3, Line 367: int64_t sys_alloc_time = sys_alloc_sw.ElapsedTime(); Shouldn't we move this line up by one line to only measure the allocation time? -- To view, visit http://gerrit.cloudera.org:8080/11947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12b740b8ea7773b3215681531dfa62db55cfdf18 Gerrit-Change-Number: 11947 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 28 Nov 2018 15:30:01 +0000 Gerrit-HasComments: Yes
