Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12008 )
Change subject: IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12008/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/12008/1/docs/shared/impala_common.xml@3668 PS1, Line 3668: an Impala dynamic resource pool, you must also specify the Default Query This looks like it needs updating since "Minimum Query Memory Limit" and "Maximum Query Memory Limit" is also an option. http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml File docs/topics/impala_admission.xml: http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml@139 PS1, Line 139: This is the technique to use once you have a stable workload with well-understood memory requirements. I feel like this sentence doesn't add anything. http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml@167 PS1, Line 167: e Default Query Memory Limit unset I missed this in the draft I sent you - this note only applies if you set neither "Default..." or the Min/Max. http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml@697 PS1, Line 697: In a real : deployment they might contain other settings for use with various : aspects of the YARN component. I find this sentence confusing. Maybe the paragraph should just say that these files define resource pools for Impala Admission Control and are separate from the similar fair-scheduler.xml that defines resource pools for YARN. -- To view, visit http://gerrit.cloudera.org:8080/12008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b Gerrit-Change-Number: 12008 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 30 Nov 2018 00:31:29 +0000 Gerrit-HasComments: Yes
