Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 )
Change subject: IMPALA-7738: Implement timeouts for HDFS open calls ...................................................................... Patch Set 11: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/11874/11/be/src/util/thread-pool.h File be/src/util/thread-pool.h: http://gerrit.cloudera.org:8080/#/c/11874/11/be/src/util/thread-pool.h@272 PS11, Line 272: /// Otherwise, it returns the status returned by ExecuteImpl(). s/ExecuteImpl/Execute? (This was fixed on line 263, but not here on 272, I think.) http://gerrit.cloudera.org:8080/#/c/11874/11/tests/custom_cluster/test_hdfs_timeout.py File tests/custom_cluster/test_hdfs_timeout.py: http://gerrit.cloudera.org:8080/#/c/11874/11/tests/custom_cluster/test_hdfs_timeout.py@43 PS11, Line 43: # Find the NameNode's pid via jps : jps_output = check_output(["jps"]) : namenode_pid = None : for line in jps_output.split("\n"): : pid, procname = line.split(" ") : if procname == "NameNode": : namenode_pid = pid : break : assert(namenode_pid is not None) This is totally fine. You can semi-equivalently do: "pgrep -f namenode.NameNode". -- To view, visit http://gerrit.cloudera.org:8080/11874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia14403ca5f3f19c6d5f61b9ab2306b0ad3267454 Gerrit-Change-Number: 11874 Gerrit-PatchSet: 11 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 03 Dec 2018 21:47:46 +0000 Gerrit-HasComments: Yes
