Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11992 )

Change subject: IMPALA-2343: Add lifecycle timeline to plan nodes
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11992/10/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:

http://gerrit.cloudera.org:8080/#/c/11992/10/tests/query_test/test_observability.py@203
PS10, Line 203:     """Test that ExecNode events show up in a profile."""
> Do we have a mechanism to check that these show up in all plan node types?
Nothing quite like that, no, although it would be good in general to have some 
infrastructure to do that kind of thing.



--
To view, visit http://gerrit.cloudera.org:8080/11992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15341bdb15022bad9814882689ce5cb2939f4653
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Mon, 03 Dec 2018 22:13:51 +0000
Gerrit-HasComments: Yes

Reply via email to