Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 )
Change subject: IMPALA-7914: Base interface for statement-like AST nodes ...................................................................... Patch Set 2: Code-Review+2 (4 comments) Nice cleanup. Looking forward to the future changes that fix the expr-analyze() lifecycle. http://gerrit.cloudera.org:8080/#/c/12018/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12018/2//COMMIT_MSG@17 PS2, Line 17: While Expr still defines this method for now, : the future goal is to change the Expr analyze() semantics. Mind adding a TODO for this? http://gerrit.cloudera.org:8080/#/c/12018/2/fe/src/main/java/org/apache/impala/analysis/StmtNode.java File fe/src/main/java/org/apache/impala/analysis/StmtNode.java: http://gerrit.cloudera.org:8080/#/c/12018/2/fe/src/main/java/org/apache/impala/analysis/StmtNode.java@23 PS2, Line 23: clauses nit: period after this. http://gerrit.cloudera.org:8080/#/c/12018/2/fe/src/main/java/org/apache/impala/analysis/StmtNode.java@25 PS2, Line 25: They are not subject to expression rewrites. This seems out of context for anyone who reads the code and don't know about this commit. http://gerrit.cloudera.org:8080/#/c/12018/2/fe/src/main/java/org/apache/impala/analysis/StmtNode.java@24 PS2, Line 24: before- : * of after- rewrite SQL typo? -- To view, visit http://gerrit.cloudera.org:8080/12018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie565ff02ad74f805a667017ba9bc8c0a2697a97b Gerrit-Change-Number: 12018 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 00:02:47 +0000 Gerrit-HasComments: Yes
