Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 )
Change subject: IMPALA-6924: Add child queries to profile in compute stats ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/11977/4/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/11977/4/be/src/service/client-request-state.cc@572 PS4, Line 572: child_queries.emplace_back(compute_stats_params.tbl_stats_query, this, > I know you didn't write this line, but I see some people advocating that em Obviously not a big deal since this isn't a super perf critical piece of code, but you're right so I went ahead and made the change. http://gerrit.cloudera.org:8080/#/c/11977/4/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/11977/4/be/src/service/impala-hs2-server.cc@907 PS4, Line 907: DCHECK(request.format == TRuntimeProfileFormat::STRING || request.format == TRuntimeProfileFormat::BASE64); > So this covers both the string and base64 cases? Right, in the base64 case we're still just returning a string, so I'm using the same out parameter to GetRuntimeProfileOutput() 'ss' for both cases. Obviously a bit messy/confusing but I didn't see a better way to rewrite GetRuntimeProfileOutput(). I added a DCHECK to make it clearer. http://gerrit.cloudera.org:8080/#/c/11977/4/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/11977/4/be/src/util/runtime-profile-test.cc@93 PS4, Line 93: EXPECT_TRUE(deserialized_profile->GetCounter("Not there") == nullptr); > == nullptr Done http://gerrit.cloudera.org:8080/#/c/11977/4/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/11977/4/be/src/util/runtime-profile.cc@888 PS4, Line 888: uint32_t deserialized_len = static_cast<uint32_t>(result_len); > Would there be any advantage to using a cast here? My understanding is that it doesn't make a difference to how things run, but it does make the operation more explicit, which is helpful, so I went ahead and did it. http://gerrit.cloudera.org:8080/#/c/11977/4/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/11977/4/tests/query_test/test_observability.py@265 PS4, Line 265: # Search for all query ids (max length 33) in the profile. > So 33 is the length of a query id? That made me think. Added a comment -- To view, visit http://gerrit.cloudera.org:8080/11977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5006c3b366d381eed4687e550cdfc463be3d1350 Gerrit-Change-Number: 11977 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Dec 2018 19:04:12 +0000 Gerrit-HasComments: Yes
