Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 )
Change subject: IMPALA-7902: NumericLiteral fixes, refactoring ...................................................................... Patch Set 9: (6 comments) Thanks Tim for the additional review. Addressed the review comments. http://gerrit.cloudera.org:8080/#/c/12001/9/fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java File fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java: http://gerrit.cloudera.org:8080/#/c/12001/9/fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java@128 PS9, Line 128: public NumericLiteral(String value, Type t) throws SqlCastException { > Maybe worth a brief comment to explain that it accepts any numeric format s Done http://gerrit.cloudera.org:8080/#/c/12001/9/fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java@202 PS9, Line 202: public static NumericLiteral create(long value, Type type) { > QueryStmt.setLimit() could use this (it converts a long to a string for som Thanks for point out this improvement. Even simpler is to use the string-based constructor above, since very valid long is also a valid BigDecimal. http://gerrit.cloudera.org:8080/#/c/12001/9/fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java@326 PS9, Line 326: > nit: extra blank line Done http://gerrit.cloudera.org:8080/#/c/12001/9/fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java@389 PS9, Line 389: float > nit: floating Done http://gerrit.cloudera.org:8080/#/c/12001/9/fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java@406 PS9, Line 406: else the cast is done in place. > This is a bit confusing - does this just mean that the original 'value' is Done http://gerrit.cloudera.org:8080/#/c/12001/9/fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java@421 PS9, Line 421: return > Weird formatting Done -- To view, visit http://gerrit.cloudera.org:8080/12001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I484600747b2871d3a6fe9153751973af9a8534f2 Gerrit-Change-Number: 12001 Gerrit-PatchSet: 9 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 05 Dec 2018 01:42:40 +0000 Gerrit-HasComments: Yes
