Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 )
Change subject: IMPALA-7807: Analysis test fixture ...................................................................... Patch Set 9: Fixed the build issue; it resulted from an earlier fix in response to a review comment. Also took this opportunity to revise the code to reflect what has been learned in the last few weeks. Divided up the tasks somewhat differently. The rewrite fixture is in the one test that uses it. (The mechanism it tests is in the process of being deprecated, so the fixture is temporary.) Please take a look to see if the revised form is easier to follow. -- To view, visit http://gerrit.cloudera.org:8080/11881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id69c99b284960f16394f61072d38dd00269bc10c Gerrit-Change-Number: 11881 Gerrit-PatchSet: 9 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Comment-Date: Mon, 10 Dec 2018 18:53:45 +0000 Gerrit-HasComments: No
