Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 )
Change subject: IMPALA-7931: fix executor shutdown races ...................................................................... Patch Set 7: (10 comments) http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/runtime/coordinator-backend-state.h@291 PS7, Line 291: boost::unique_lock Did we decide on moving to std::unique_lock in the long run ? I cannot quite recall what we agreed on in the last discussion. http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/runtime/coordinator.cc@835 PS7, Line 835: : nit: space http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/runtime/coordinator.cc@835 PS7, Line 835: (BackendState* backend_state: backend_states_) { This may be very unlikely in practice but is there a chance this loop race with InitBackendStates() ? http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/service/cancellation-work.h File be/src/service/cancellation-work.h: http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/service/cancellation-work.h@18 PS7, Line 18: #pragma once Interesting. So, that's the new convention we are gonna use in the future ? http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/service/cancellation-work.h@31 PS7, Line 31: EXPIRED, Will "LIMIT_EXCEEDED" be a better name ? Sounds to me the reason for cancellation is either "time limit exceeded" or "some resource limit exceeded". http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/service/cancellation-work.h@80 PS7, Line 80: TUniqueId query_id_; const TUniqueId query_id_; ? Same for other fields below. http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/service/impala-server.cc@1406 PS7, Line 1406: vector<TNetworkAddress> active_backends = const http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/service/impala-server.cc@1800 PS7, Line 1800: cancellation_entry->first, cancellation_entry->second)); nit: wrong indent http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/util/impalad-metrics.h File be/src/util/impalad-metrics.h: http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/util/impalad-metrics.h@49 PS7, Line 49: executed nit: started. Precisely speaking, the counter is incremented when a query starts on a backend. It may not have completed. This may just be a minor distinction. Feel free to ignore. http://gerrit.cloudera.org:8080/#/c/12082/7/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/12082/7/common/thrift/metrics.json@483 PS7, Line 483: .. nit: duplicated "." -- To view, visit http://gerrit.cloudera.org:8080/12082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c1a80304cb6695d228aca8314e2231727ab1998 Gerrit-Change-Number: 12082 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 19 Dec 2018 00:54:44 +0000 Gerrit-HasComments: Yes
