Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12068 )
Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12068/4/be/src/exprs/is-not-empty-predicate-ir.cc File be/src/exprs/is-not-empty-predicate-ir.cc: http://gerrit.cloudera.org:8080/#/c/12068/4/be/src/exprs/is-not-empty-predicate-ir.cc@24 PS4, Line 24: CollectionVal coll = children_[0]->GetCollectionVal(eval, row); As discussed offline, we should be able to remove this virtual function call http://gerrit.cloudera.org:8080/#/c/12068/4/be/src/exprs/valid-tuple-id-ir.cc File be/src/exprs/valid-tuple-id-ir.cc: http://gerrit.cloudera.org:8080/#/c/12068/4/be/src/exprs/valid-tuple-id-ir.cc@33 PS4, Line 33: for (int i = 0; i < num_tuples; ++i) { As discussed offline, we should be able to unroll this loop -- To view, visit http://gerrit.cloudera.org:8080/12068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb87b9e3b879c278ce8638d97bcb320a7555a6b3 Gerrit-Change-Number: 12068 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Wed, 19 Dec 2018 18:49:52 +0000 Gerrit-HasComments: Yes
