Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12116 )
Change subject: WIP IMPALA-7550 Add documentation to profile counters ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12116/1/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/12116/1/be/src/util/runtime-profile-counters.h@101 PS1, Line 101: class ProfileEntryPrototype { I mentioned this directly but will add a comment just to make it easier to keep track of. I think it would be helpful to document the stability of the different counters. I can think of maybe three different categories: * Stable counters - generally useful to understand query performance, should only change rarely and if it does we'll make some effort to notify users. E.g. BytesRead. * Unstable but useful - useful to understand query performance, but subject to change, particularly if the implementation changes. E.g. RowBatchQueuePutWaitTime, MaterializeTupleTimer * Debugging counters - generally not useful to users of Impala, the main use case is low-level debugging. Can be hidden to reduce noise for most consumers of profiles. Maybe there's also not a distinction between the last two categories. -- To view, visit http://gerrit.cloudera.org:8080/12116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaa0a44f0a996f3487566b545d984d562e6e1588 Gerrit-Change-Number: 12116 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 20:11:02 +0000 Gerrit-HasComments: Yes
