Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 )
Change subject: IMPALA-7968, Part 1: JSON serialization framework ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/12079/6/fe/src/main/java/org/apache/impala/common/serialize/JacksonTreeSerializer.java File fe/src/main/java/org/apache/impala/common/serialize/JacksonTreeSerializer.java: http://gerrit.cloudera.org:8080/#/c/12079/6/fe/src/main/java/org/apache/impala/common/serialize/JacksonTreeSerializer.java@204 PS6, Line 204: _objectFieldValueSeparatorWithSpaces = DEFAULT_SEPARATORS.getObjectFieldValueSeparator() + " "; line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/12079/6/fe/src/test/java/org/apache/impala/common/serialize/JacksonTreeSerializerTest.java File fe/src/test/java/org/apache/impala/common/serialize/JacksonTreeSerializerTest.java: http://gerrit.cloudera.org:8080/#/c/12079/6/fe/src/test/java/org/apache/impala/common/serialize/JacksonTreeSerializerTest.java@22 PS6, Line 22: import org.apache.impala.common.serialize.JacksonTreeSerializer.JacksonTreeStringSerializer; line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3101c2708bf6cf4bec61af83a5db9b6d70ddd9c Gerrit-Change-Number: 12079 Gerrit-PatchSet: 6 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 27 Dec 2018 21:27:48 +0000 Gerrit-HasComments: Yes
