Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12142 )
Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/12142/1/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: http://gerrit.cloudera.org:8080/#/c/12142/1/be/src/runtime/coordinator-backend-state.h@294 PS1, Line 294: Status DoCancelQueryFInstancesRrpcWithRetry( Nit: The prevailing style seems to place reference ('&') and pointer ('*') symbols next to the pointed-to-type, rather than next to the variable name. Comment applies for the entire review. http://gerrit.cloudera.org:8080/#/c/12142/1/be/src/scheduling/query-schedule.h File be/src/scheduling/query-schedule.h: http://gerrit.cloudera.org:8080/#/c/12142/1/be/src/scheduling/query-schedule.h@104 PS1, Line 104: const TNetworkAddress& krpc_host, int per_fragment_instance_idx, Nit: I wonder if there are trailing whitespaces in these lines? I don't understand why some lines are marked as changed... http://gerrit.cloudera.org:8080/#/c/12142/1/be/src/scheduling/scheduler.h File be/src/scheduling/scheduler.h: http://gerrit.cloudera.org:8080/#/c/12142/1/be/src/scheduling/scheduler.h@433 PS1, Line 433: void ComputeFragmentExecParams(const BackendConfig executor_config, Nit: Please retain existing placement of '&' and '*'. Also: Are you intentionally passing executor_config by value? Here and in the following functions? http://gerrit.cloudera.org:8080/#/c/12142/1/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/12142/1/be/src/scheduling/scheduler.cc@333 PS1, Line 333: ComputeFragmentExecParams(executor_config, plan_exec_info, Nit: Trailing spaces? http://gerrit.cloudera.org:8080/#/c/12142/1/common/protobuf/control_service.proto File common/protobuf/control_service.proto: http://gerrit.cloudera.org:8080/#/c/12142/1/common/protobuf/control_service.proto@163 PS1, Line 163: optional UniqueIdPB query_id = 1; Don't understand how the query id can be optional... http://gerrit.cloudera.org:8080/#/c/12142/1/common/protobuf/control_service.proto@179 PS1, Line 179: // Cancellation is asynchronous. Commit message says cancellation is synchronous. Do you want to change this comment until async cancellation is implemented? -- To view, visit http://gerrit.cloudera.org:8080/12142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I625030c3f1068061aa029e6e242f016cadd84969 Gerrit-Change-Number: 12142 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Jan 2019 19:29:27 +0000 Gerrit-HasComments: Yes
