Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12132 )
Change subject: Fix some warnings on GCC7 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) > (1 comment) > > My feeling is that it's not worth adding the comments - when we do > bump the compiler version it'll be enforced automatically. It's > possible someone will "fix" it in the meantime if it looks weird > and they don't do a "git blame" to understand why, but I think we > can live with that possibility. That makes sense. http://gerrit.cloudera.org:8080/#/c/12132/2/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: http://gerrit.cloudera.org:8080/#/c/12132/2/be/src/exprs/decimal-operators-ir.cc@585 PS2, Line 585: DCHECK(result == StringParser::PARSE_SUCCESS : || result == StringParser::PARSE_UNDERFLOW); > The issue here was the missing "result ==". GCC7 warns when an enum is coer Ah, misread this. -- To view, visit http://gerrit.cloudera.org:8080/12132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39a12bc5ed6957c147b7f0dba85c7687cc989439 Gerrit-Change-Number: 12132 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 03 Jan 2019 18:03:33 +0000 Gerrit-HasComments: Yes
