Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 )
Change subject: IMPALA-6521: Show experimental flags in /varz and log files ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/12152/2/be/src/common/logging.cc File be/src/common/logging.cc: http://gerrit.cloudera.org:8080/#/c/12152/2/be/src/common/logging.cc@165 PS2, Line 165: } > better to use a stringstream for building strings (appending to string can Done http://gerrit.cloudera.org:8080/#/c/12152/2/be/src/common/logging.cc@166 PS2, Line 166: } > I'm confused by this iteration logic. Why not something like: Done http://gerrit.cloudera.org:8080/#/c/12152/2/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12152/2/tests/custom_cluster/test_web_pages.py@35 PS2, Line 35: [e for > I think list comprehensions are generally preferred to filter() in python - TIL. Done. -- To view, visit http://gerrit.cloudera.org:8080/12152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e Gerrit-Change-Number: 12152 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 04 Jan 2019 01:08:38 +0000 Gerrit-HasComments: Yes
