Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 )
Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement ...................................................................... Patch Set 15: (8 comments) http://gerrit.cloudera.org:8080/#/c/11888/14/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11888/14/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1162 PS14, Line 1162: catalog object > nit: ..objects added.. (below too) Done http://gerrit.cloudera.org:8080/#/c/11888/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/11888/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@75 PS14, Line 75: catalog > nit: catalog Done http://gerrit.cloudera.org:8080/#/c/11888/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@261 PS14, Line 261: authzDelta.getRemovedCatalogObjects().add( > Log something here for debugging? Done http://gerrit.cloudera.org:8080/#/c/11888/14/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/11888/14/tests/authorization/test_authorization.py@524 PS14, Line 524: y adding and removing r > rephrase? Done http://gerrit.cloudera.org:8080/#/c/11888/14/tests/authorization/test_authorization.py@529 PS14, Line 529: > nit: I think you can directly do: Done http://gerrit.cloudera.org:8080/#/c/11888/14/tests/authorization/test_authorization.py@550 PS14, Line 550: > add a docstring Done http://gerrit.cloudera.org:8080/#/c/11888/14/tests/authorization/test_authorization.py@591 PS14, Line 591: self.role_cleanup("%s_%s" % (unique_role, suffix)) > doc string Done http://gerrit.cloudera.org:8080/#/c/11888/14/tests/authorization/test_authorization.py@606 PS14, Line 606: result = self.execute_query_expect_success(self.client, "show grant role %s" % : unique_role) > nit: should we loop this for all the clients? Done -- To view, visit http://gerrit.cloudera.org:8080/11888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5459e1c97b12dee307e0cf85b94a9f66fd9d9a8c Gerrit-Change-Number: 11888 Gerrit-PatchSet: 15 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Fri, 04 Jan 2019 02:38:27 +0000 Gerrit-HasComments: Yes
