Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12143 )
Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/12143/1/fe/src/main/java/org/apache/impala/analysis/CaseExpr.java File fe/src/main/java/org/apache/impala/analysis/CaseExpr.java: http://gerrit.cloudera.org:8080/#/c/12143/1/fe/src/main/java/org/apache/impala/analysis/CaseExpr.java@404 PS1, Line 404: whenExpr = exprAnalyzer.analyzer().getConstantFolder().rewrite(pred, exprAnalyzer.analyzer()); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/12143/1/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java File fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java: http://gerrit.cloudera.org:8080/#/c/12143/1/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java@380 PS1, Line 380: * Takes the children of an OR predicate and attempts to combine them into a single IN predicate. line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/12143/1/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java@381 PS1, Line 381: * The transformation is applied if both children are equality predicates with a literal on the line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/12143/1/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/12143/1/fe/src/main/java/org/apache/impala/analysis/Expr.java@444 PS1, Line 444: protected Expr rewrite(ExprAnalyzer exprAnalyzer) throws AnalysisException { return this; } line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/12143/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/12143/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@710 PS1, Line 710: * Simplify COALESCE by skipping leading nulls and applying the following transformations: line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12143/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@726 PS1, Line 726: List<Expr> newChildren = Lists.newArrayList(getChildren().subList(i, numChildren)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12143/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@750 PS1, Line 750: return new FunctionCallExpr(new FunctionName("count"), FunctionParams.createStarParam()); line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifda7082abea4f6448e6cfef0d9ef7b8565d73fce Gerrit-Change-Number: 12143 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Mon, 07 Jan 2019 01:12:34 +0000 Gerrit-HasComments: Yes
